search

evalphobia / logrus_sentry

sentry hook for logrus
MIT License
194 stars 78 forks source link

Rename sirupsen to Sirupsen #53

Closed sysradium closed 7 years ago

sysradium commented 7 years ago

There is an issue with this lib when is used together with the glide vendoring tool.

If I add logrus_sentry as a dependency to the glide.yml I will end up with this errors during glide install:

[INFO]  --> Fetching updates for github.com/sirupsen/logrus.
[ERROR] Error looking for github.com/sirupsen/logrus: The Remote does not match the VCS endpoint

This is because you specify github.com/sirupsen/logrus as a dependency instead of github.com/Sirupsen/logrus. It breaks only on case-sensitive FS (for example OSX).

Refence: https://github.com/Masterminds/glide/issues/781

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 83.102% when pulling 1edc0016b5ad0a559af4d2ceef5c43c05a123be2 on sysradium:master into 9f8f2d05a621e616d9341ac75374eb8402ae0630 on evalphobia:master.

arp242 commented 7 years ago

sirupsen is the name that should be used; this got changed in #48. If there are projects that use the old Sirupsen name then those should be updated, too.

You can probably get away by manually renaming the repo in the glide files?

The entire Sirupsen -> sirupsen is annoying, but keeping the old name isn't really going to work in the long term. Loads of projects are renaming it now, see the references in https://github.com/sirupsen/logrus/pull/384

sysradium commented 7 years ago

Ok, I see. Thanks for the explanation. This sucks a lot :(

arp242 commented 7 years ago

BTW I noticed just now that in the README it mentions:

Seeing weird case-sensitive problems? It's in the past been possible to import Logrus as both upper- and lower-case. Due to the Go package environment, this caused issues in the community and we needed a standard. Some environments experienced problems with the upper-case variant, so the lower-case was decided. Everything using logrus will need to use the lower-case: github.com/sirupsen/logrus. Any package that isn't, should be changed.

I am terribly sorry for this inconvenience. Logrus strives hard for backwards compatibility, and the author failed to realize the cascading consequences of such a name-change. To fix Glide, see these comments.

So maybe try that to fix your problem?