search

evalphobia / logrus_sentry

sentry hook for logrus
MIT License
194 stars 78 forks source link

Error: not enough arguments in call to raven.NewStacktraceFrame #67

Closed daniel-gil closed 5 years ago

daniel-gil commented 5 years ago

Hi,

the package from https://github.com/getsentry/raven-go/ has a new release which should be a minor change but seems a major one, because has added a new argument to a function:

v 0.1.0: func NewStacktraceFrame(pc uintptr, file string, line, context int, appPackagePrefixes []string) *StacktraceFrame v 0.1.1: func NewStacktraceFrame(pc uintptr, fName, file string, line, context int, appPackagePrefixes []string) *StacktraceFrame

This change causes the following error on the logrus_sentry package:


vendor/github.com/evalphobia/logrus_sentry/sentry.go:316:36: not enough arguments in call to raven.NewStacktraceFrame
        have (uintptr, string, int, int, []string)
        want (uintptr, string, string, int, int, []string)``` 

You could use gopkg to control which third-party version use, or update your package.

Regards,
Dani
daniel-gil commented 5 years ago

Hello,

the problem seems resolved.

The package https://github.com/getsentry/raven-go/ has released a new version v0.1.2 that fixes the previous problem and now the logrus_sentry package works again.

Regards, Dani