Compile error after braking change in pkg/errors

evalphobia / logrus_sentry

sentry hook for logrus

MIT License

194 stars 78 forks source link

Compile error after braking change in pkg/errors #74

Open arcana261 opened 5 years ago

arcana261 commented 5 years ago

Hiiiiiii

Today a breaking change in github.com/pkg/errors package was merged which changes type for errors.Frame from a simple program counter to runtime.Frame.

github.com/evalphobia/logrus_sentry/sentry.go:314:16 cannot convert stFrames[i] (type "github.com/pkg/errors".Frame) to type uintptr

I will work on a MR right away

mexisme commented 5 years ago

Is https://github.com/pkg/errors/issues/188 related to this? As it looks like related PR https://github.com/pkg/errors/pull/183 has just been merged.

arcana261 commented 5 years ago

@mexisme Yes dear good sir..

evalphobia commented 5 years ago

@arcana261 Thanks 🍡 #75 has been Merged. https://github.com/evalphobia/logrus_sentry/releases/tag/v0.7.0

arcana261 commented 5 years ago

OMG They've done it again :'( :'( :'(

arcana261 commented 5 years ago

I've again submitted another PR #76 which reverts us to using just PC's.