search

evan-buss / openbooks

Search and Download eBooks
https://evan-buss.github.io/openbooks/
MIT License
1.78k stars 58 forks source link

Possibly wrong IRC protocol implementation #107

Closed ncryptedV1 closed 1 year ago

ncryptedV1 commented 1 year ago

The initial USER command seems to send the wrong data. According to the RFC2812 the second parameter should most likely be 0 and the third one *. The affected line can be found here: https://github.com/evan-buss/openbooks/blob/91bb21ac7d8d2b09e1117d1a573184b000feadb0/irc/irc.go#L43

evan-buss commented 1 year ago

Good catch. Not sure where I got the original message format but it does seem to be incorrect... Do you want to submit a PR?