evan-buss / openbooks

Search and Download eBooks
https://evan-buss.github.io/openbooks/
MIT License
1.78k stars 58 forks source link

No search results returned #120

Open ljo123 opened 1 year ago

ljo123 commented 1 year ago

Running the latest version 4.5.0 and added both --name "randomuser123" and --useragent "HexChat 2.9.1" to my docker-compose. Docker logs show that client is connected and "CONNECT Message Received". Then I enter a search and see "SEARCH Message Received" but the results are blank. I tried a few popular books so I'd expect to see some results at least. My compose...

  openbooks:
    image: evanbuss/openbooks:latest
    container_name: openbooks
    volumes:
      - /path/to/books:/books
    ports:
      - 8585:80
    command: --persist --no-browser-downloads --name "randomuser123" --useragent "HexChat 2.9.1"
    restart: unless-stopped

Any ideas?

evan-buss commented 1 year ago

Do you see a "Search Accepted Into Queue" notification in the browser? If not, it's possible you're temporarily banned in the IRC channel. If you enable logs with the --log flag it will write a log file with all the IRC messages sent to your client.

ljo123 commented 1 year ago

I don't get the search accepted notification. Logs seem to show that I am connected with some welcome messages, then a list of books followed by:

:hyrule.tx.us.irchighway.net 366 randomuser123 #ebooks :End of /NAMES list.
:ChanServ!services@services.irchighway.net NOTICE randomuser123 :[#ebooks] [#ebooks] Welcome to #ebooks. Read the channel topic for current information!

Then a few PRIVMSG with some ebooks before I stopped the container which showed:

:macru!macru@ihw-8vr.1uu.22.173.IP QUIT :Quit: Leaving

I couldn't see any notification of the search I submitted in the logs.

daedric7 commented 1 year ago

Can confirm. I really don't see any error in the logs:

OpenBooks  | 2023/01/10 01:39:13 CLIENT (daedric): New client created.
OpenBooks  | 2023/01/10 01:39:13 CLIENT (daedric): CONNECT Message Received
OpenBooks  | 2023/01/10 01:39:23 CLIENT (daedric): SEARCH Message Received

And that's it.

Logs:

:asgard.fr.eu.irchighway.net 353 daedric = #ebooks :xstit Macbeth Paciffic CD123 toegunde2 Narcissio Gurbs dredhammer alxgc_000 G7b9 tinear JavaGuy gabia_ @SearchOok ronnnn Worn_Socks phantomaudio10 khay Rotech oneoneone clearmoon247 emea test123 HenryFlower limon maya__ vande Tore tomc peregrine SN0Wball dahlsal QuestionableActionable joe1235813 feygan chikkiswami_iyengar nekolicious lobo jellyb Haywire Ashara ozpekat xjane arstneio jamestsolo applehead Rigg aholic mogambo kiki_lamb Radigast N15NY John_ 
:asgard.fr.eu.irchighway.net 353 daedric = #ebooks :Loudis_ Brocker PixelScum redz stormj chaiqueen jdass budujawa hirad bjtheone shmirgelka23 znwybaq noLibre spangz scry Bastich Red_Streak lochutus Serop lucaz valibum entr0py Ryllharu reborn Maxattax Masinac ripley kinopu naiichaitofu Dorrin2311 oneone taco [MYCROFT] kollymolly biglll bbrouil2 reverie__ Soulz wahada99 oreo r0ck0 LobsterFiFee VVN Fakus666|2 flamethrower DT Neverbroken darkinfintiy123 mad_hatter_md01 ShadowFox remial jrr 
:asgard.fr.eu.irchighway.net 353 daedric = #ebooks :hawjjjjjjjjj7373737377 snakedoc bertolaz Hungry_BiB_MM Nrml Butthurtz zippy{SZ} atpeace acerbic olivr _Maru_ raye_UB rhlesaber &afaiktoit getmethisbk dfdf Marquzassea Mediaicon Euphonium Clarth Pidera1977 ymour byul178 Gandeida1 unRAIDER_Books sherrrlock DeusE yuzzel +DeathCookie wheresthemead secondsabre bmc5311 @Sophist-UK FGSD DukkkM m1n10n AJR JustOneMore Bear timbuk2 sbobsqpants Caldazar171 stevewilk123 armen_ Guest59 cadae +Trainpacks Klora eggb_ 
:asgard.fr.eu.irchighway.net 353 daedric = #ebooks :@QuietSilence rick treonomapatatra guy +dragnbreaker nobodyreally SketchyStevee dodirty14 +ps2 br0skt0t lkernel Adept jonnybuck Rasp Sabine182 mdnfa lysanderslair ShaRose ekalska luciusquintus allanon lsk st0ner slantyeyecandy13 dan F3s34sMD gummybear +Horla &MNQ nospam jeffrey jumbo Fekall &asterisk_ +Profane Gooberpatrol66 TekWiz xoppaw m0nkeyC lepik aaronbook20203 SWVZK abruptly_turgid Airwolf UMpersEgaR olleman Deadite Lord_Damian GenAkbar z32w3 
:asgard.fr.eu.irchighway.net 353 daedric = #ebooks :kernel667neighbor Duckless2653 aglaonike td00 baglady khalel shenal Foamyth squabbledabble gcomyn Tominator cybernutt beandip phero Radonio Minky Little_Love malevolence stux inky vnnv robbonnechere1111111111111114 Neckyvs theparadox Silver_ mel_t intel_dork Sandlayth BoinkBoink slabs wordupbawse DisplayError billymitchell badbwg glassbell anonymousrandom01 apwoeifjpaoweifjp SimoH SpitFire1992 leptonix kax ciapsnev Paladinz AndroUser2 tunz klgri__ p33t 
:asgard.fr.eu.irchighway.net 353 daedric = #ebooks :AssDragon someonerandom laerte zhondo rand0mdud3 smlk @shytot Daerhan RodneyD _ashbreeze_ arkaine56 phrygyda iloveglider2 turd_ferguso tacofreak86 mmoors12 Media Help_PCS ChuckleFist knotted_ jackstamina thelounge5083076142 Dukkk Simondalt rapid_pattern_1 yakisaba yo dragon|fire berill sniffn2 shmirgel 
:asgard.fr.eu.irchighway.net 366 daedric #ebooks :End of /NAMES list.
:ChanServ!services@services.irchighway.net NOTICE daedric :[#ebooks] [#ebooks] Welcome to #ebooks. Read the channel topic for current information!
:JustOneMore!naj@ihw-uk14i7.sub-174-192-82.myvzw.com PRIVMSG #ebooks : @search Jessica Coulter Smith
:Greagle!kvirc@ihw-drb.2cg.78.208.IP PRIVMSG #ebooks :@search David Niall Wilson -The Devil’s in the Flaws
:jdass!jdass@ihw-gifbrt.cpe.pppoe.ca PRIVMSG #ebooks :!Dumbledore Steven Pressfield - The War of Art- Break Through the Blocks and Win Your Inner Creative Battles (epub).rar

Search event on the browser here (Search request sent)

:nbirimac!nbirimac@ihw-gdg.93b.140.158.IP JOIN :#ebooks
:bookee1640!bookee1640@ihw-vhi.p88.247.84.IP PRIVMSG #ebooks :!Horla Emily France - Zen and Gone (epub).epub
:Greagle!kvirc@ihw-drb.2cg.78.208.IP QUIT :Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/
:herring!theRedPickl@ihw-d94.n3c.37.89.IP JOIN :#ebooks
:TVguy2345!Bookguy@ihw-0gr.ocg.167.142.IP PRIVMSG #ebooks :!dragnbreaker Sanderson, Brandon - Mistborn 04 - The Alloy of Law (v5.0).epub
:Ascalon_!Ascalon@ihw-t1c.71f.216.209.IP QUIT :Ping timeout: 121 seconds
:AlternaServ!anon@ihw-4f1.adg.98.207.IP PRIVMSG #ebooks :05,00Alternative books,articles,docs,etc.14,00 07,00Type:05,00 @AlternaServ 07,00For My List Of:05,00 2,159 07,00Files 14,00 07,00Slots:05,00 5/5 14,00 07,00Queued:05,00 0 14,00 07,00Speed:05,00 0cps 14,00 07,00Next: 05,00NOW 14,00 07,00Served:05,00 5 14,00 07,00List: 05,00Jan 7th 14,00 07,00Search: 05,00ON 14,00 07,00Mode: 05,00Normal 14,00
:jdass!jdass@ihw-gifbrt.cpe.pppoe.ca PRIVMSG #ebooks :@search Turning Pro by Steven Pressfield
:AlternaServ!anon@ihw-4f1.adg.98.207.IP PRIVMSG #ebooks :SLOTS 5 5 NOW 0 999 0 2159 14190090861 0 1673091547 226080 OmenServe v2.72
:myarlapbc!myarlapbc@ihw-6u4.3f8.110.216.IP PRIVMSG #ebooks :!phoomphy Fantasy AGE - Basic Rulebook.pdf
:Dopey_lopey_7!Dopey_lopey@ihw-pcqpni.dsl.bell.ca PRIVMSG #ebooks :!phoomphy Choose Your Own Adventure 29 - The Fairy Kidnap.pdf
:w3ss18!w3ss183@ihw-ivr.msr.126.142.IP PRIVMSG #ebooks :!Dumbledore Daisy Meadows - (Rainbow Magic - Ocean Fairies 03) - Pia the Penguin Fairy (retail).epub
:w3ss18!w3ss183@ihw-ivr.msr.126.142.IP PRIVMSG #ebooks :!Dumbledore Daisy Meadows - (Rainbow Magic - Ocean Fairies 05) - Stephanie the Starfish Fairy (retail).epub
:w3ss18!w3ss183@ihw-ivr.msr.126.142.IP PRIVMSG #ebooks :!Dumbledore Daisy Meadows - (Rainbow Magic - Ocean Fairies 06) - Whitney the Whale Fairy (retail).epub
:w3ss18!w3ss183@ihw-ivr.msr.126.142.IP PRIVMSG #ebooks :!Dumbledore Daisy Meadows - (Rainbow Magic - Ocean Fairies 07) - Courtney the Clownfish Fairy (retail).epub
smee42 commented 1 year ago

I'm also seeing exactly the same thing since updating to the latest version. Logs have the same as what daedric7 is seeing - Docker log shows the search message received, but the detailed irc log has nothing relating to the search in it.

mrodus commented 1 year ago

It seems to work for me without passing the useragent command.

hackmonker commented 1 year ago

can confirm here too. no results are shown and no search query is sent to the irc client according to logs.

daedric7 commented 1 year ago

I can confirm the issue is somewhere with Openbooks.

I joined the IRC and searches work, Search is answering via Notices, and sending search results via DCC.

ljo123 commented 1 year ago

It seems to work for me without passing the useragent command.

After you posted that I tried again without the useragent string but got the same result.

xenolithis commented 1 year ago

not seeing any results or the "Search Accepted into Queue" in browser with following conf

---
services:
  openbooks:
    image: evanbuss/openbooks:latest
    container_name: openbooks
    volumes:
      - /srv/media/downloads/:/books
    ports:
      - 12443:80
    restart: unless-stopped
    command: --persist  --name lookin4books1337 --log --no-browser-downloads
evan-buss commented 1 year ago

The IRC related changes between the latest version and the previous version are minimal. Not really sure of the cause of these issues 🤔.

Keep in mind that the IRC channel started to ban OpenBooks clients. This release provides ways to make OpenBooks look like any other IRC client.

I know they are able to block specific clients by name pattern. That's the reason for the required --name flag change.

It's also possible that they are blocking any clients with "OpenBooks" in their user agent, so do try to use the --useragent flag to specify the user agent of a standard IRC client.

Lastly, if you've been banned it may take a day or two for the IP blacklist to be removed. Try connecting via a standard IRC client or another device.

ljo123 commented 1 year ago

The IRC related changes between the latest version and the previous version are minimal. Not really sure of the cause of these issues thinking.

Keep in mind that the IRC channel started to ban OpenBooks clients. This release provides ways to make OpenBooks look like any other IRC client.

I know they are able to block specific clients by name pattern. That's the reason for the required --name flag change.

It's also possible that they are blocking any clients with "OpenBooks" in their user agent, so do try to use the --useragent flag to specify the user agent of a standard IRC client.

Lastly, if you've been banned it may take a day or two for the IP blacklist to be removed. Try connecting via a standard IRC client or another device.

I think you're right that its an IP blacklist issue. I reconfigured to run through a Gluetun VPN container and its working again.

szinn commented 1 year ago

I would concur with the IP blacklist observation. Even using Colloquy doesn't work unless I go through a VPN.

linjoe2 commented 1 year ago

trying from multiple remote and local ip's, but no result...

jonathan-shahen commented 1 year ago

The command @search is not working for me on my other manual irc client. so I am guessing that it broke. Change the search to searchook and it worked

CMD: --searchbot searchook (don't forget to add your -n <name here>

they will probably fix search once they notice. after the change everything worked in openbooks

CyBuzz commented 1 year ago

@jonathan-shahen

This worked. Thank you!!

fsegouin commented 1 year ago

I can confirm search is actively banning the client via IP somehow, even when using a custom useragent.

mbaran5 commented 1 year ago

I can confirm search is actively banning the client via IP somehow, even when using a custom useragent.

I can also confirm, using a different tool (but this issue hit via google search), that the searchbot is blocking IPs. Regardless of client I cannot @search anymore but when I use webchat on mobile/LTE I can search fine.