evan-buss / openbooks

Search and Download eBooks
https://evan-buss.github.io/openbooks/
MIT License
1.77k stars 57 forks source link

feat: use server-sent events instead of websockets #172

Closed evan-buss closed 4 days ago

evan-buss commented 4 days ago

Server-Sent Events are conceptually simpler and use the HTTP protocol. This makes them easier for self-hosters to use as they don't need to modify their reverse proxies (like nginx) to use them like websockets. I think this mostly impacted users who used subpaths rather than subdomains.

We don't really need bidirectional communication, rather just server to client because we don't know when the IRC server will respond to our messages. The requests that were previously sent over websocket have been moved to API endpoints (search / download).

sonarcloud[bot] commented 4 days ago

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud