evan-buss / openbooks

Search and Download eBooks
https://evan-buss.github.io/openbooks/
MIT License
1.77k stars 57 forks source link

refactor: remove Client #175

Closed evan-buss closed 4 days ago

evan-buss commented 4 days ago

The Client struct was only necessary when we were using websockets as it was full duplex and we received commands and sent responses. Now that we are using SSE and most of the low level details are hidden we don't need to have our own concurrent read / write loops.

It also made more sense earlier in the history of the project when each browser connection would get its own IRC connection as a Client encapsulated a single browser request / response / IRC loop. Now that we are using a single IRC connection, we can just put this state on the server struct.

sonarcloud[bot] commented 4 days ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud