search

evan-buss / openbooks

Search and Download eBooks
https://evan-buss.github.io/openbooks/
MIT License
1.79k stars 59 forks source link

Please contact fruitloops at #ebooks #52

Closed ricktoronto closed 2 years ago

ricktoronto commented 2 years ago

Please contact fruitloops in #ebooks regarding your script and its banning and how it can be coded in such a way that it is acceptable for us and users.

evan-buss commented 2 years ago

In my conversation with fruitloops, they have stated that a 10 second rate limit between search requests will be enough to reduce server load. I will work on the implementation and let them know when the new version is released.

ricktoronto commented 2 years ago

Thank you ever so much for getting back to us so quickly! Looking forward to the new version :)

lukyjay commented 2 years ago

Can this be configurable? I'm ok with setting something much higher on my install if it helps

ricktoronto commented 2 years ago

If someone wants to extend the delay, no problem. 10 seconds should be the minimum however.

janosrusiczki commented 2 years ago

Just my luck, I download this and it doesn't work. Find out it was banned 10 hours ago... I hope you guys reach an agreement.

SmartPhoneLover commented 2 years ago

Just to know, as it's the first time I install it on my server (docker). Getting stuck (infinite search) when trying to perform a search, is the result of the expected behaviour due to the ban? Also, no books are shown when I first launch the instance.

Or may I lost some params during installation?

malev commented 2 years ago

@SmartPhoneLover I believe you are experiencing this problem because openbooks has been banned. You'll have to wait for the fix

ricktoronto commented 2 years ago

NOTE: For anyone who attempts to bypass the ban, you will be permanently banned from the channel, regardless of whether you update to the new version. Please do not do this. Wait for the update.

SmartPhoneLover commented 2 years ago

NOTE: For anyone who attempts to bypass the ban, you will be permanently banned from the channel, regardless of whether you update to the new version. Please do not do this. Wait for the update.

I'm not trying to bypass it in any way. I just wanted to know if what I'm experiencing is the expectyed behaviour of being banned or delayed as described here.

ricktoronto commented 2 years ago

NOTE: For anyone who attempts to bypass the ban, you will be permanently banned from the channel, regardless of whether you update to the new version. Please do not do this. Wait for the update.

I'm not trying to bypass it in any way. I just wanted to know if what I'm experiencing is the expectyed behaviour of being banned or delayed as described here.

It may have not been you. Some one has been attempting to do so, and needless to say we are disappointed.

evan-buss commented 2 years ago

See pull request that implements search rate limiting. The default rate limit value is 1 search per 10 seconds. This wait period is configurable and can be increased but not decreased.

ricktoronto commented 2 years ago

Thanks Evan. The pull request looks great and per our conversation, feel free to release the new version!

Anyone using the old one will find that it doesn't work on the channel, so make sure to grab your update.

SmartPhoneLover commented 2 years ago

Thank you for the update!

I have another question, regarding to the comment (deleted?) from @FryMiester. (...) My- issues are, the ridiculous usernames that are generated just makes me want to automatically kick/ban each one, or at the least set ignore on my server your users need to be able to select their own nickname and register it with nickserv (...) therefore I have to manually allow their access to my server.

So, do you recommend configuring a custom (fixed) username to use the service? Because, as described by the owner of the webserver, he is having problems with the auto-generated random usernames.

evan-buss commented 2 years ago

@SmartPhoneLover You have the option to specify a custom username via CLI flags (ie openbooks server --name evan-buss). It seems that at least some of the admins would prefer this. The random name generation was just a simple way to avoid name clashes when multiple users are connected at the same time.

SmartPhoneLover commented 2 years ago

@evan-buss Ok, got it. Thank you for your quick reply.

FryMiester commented 2 years ago

I delete my previous comment because I was under the impression that fruitloops was addressing all the concerns. I suppose all the concerns of the channel administrators were addressed. The following is my opinion and may not reflect the opinion of the channel administrators or any other file servers found in #ebooks. Bots are generally not well liked and barely tolerated... this includes well behaved bots such as yours. The auto-generated usernames shout 'I am a BOT and I'm here to RAPE your collection' There have been bots come into the channel and hammer download for 3-4 days continuously. I've had one get on my server and pull 50GB of files overnight. I love to share my collection, with people, not file scraping bots. Your program does not reply to 'VERSION' queries. My server software queries any user whom requests a file. This is to assist certain IRC clients that may normally have trouble connecting, even to point of fallback to sending the file via internet anonymous file server. With your program not responding to the version query I have to manually allow users of your software, or disable that portion of my server software. My requests are this... Have your program reply to the version query with a minimum of "OpenBooks" you can add version numbering and author info if you wish. If you need assistance on the syntax for the CTCP reply I will be happy to assist. Second, have your users select/create their own usernames, and perhaps add _1, _2 for multiple instances.

Again these opinions and requests are my own and may or may not reflect the opinion of the admin or other servers. FryMiester operator and author of FWServer