evan-buss / openbooks

Search and Download eBooks
https://evan-buss.github.io/openbooks/
MIT License
1.78k stars 58 forks source link

Still reporting 4.3.0 on IRC Whois #98

Closed AdrianSimionov closed 1 year ago

AdrianSimionov commented 1 year ago

IRC Whois is still reported as 4.3.0, although the software version changed.

evan-buss commented 1 year ago

That is by design, see the following code comments.

The IRC admins require us to send the "WHOIS" response with the current version of the software. This allows them to whitelist / blacklist specific versions of OpenBooks.

Unless they contact me and tell me something is wrong (rate limiting broken / other server abuses), I will keep the IRC version the same even when the release version increments.

AdrianSimionov commented 1 year ago

This looks very much as an abuse to me.

While I do understand your statement around the success of the application, I still believe such a rule is more like a collar to make sure this tool can be controlled.