evanberkowitz / supervillain

MCMC for modified Villain constructions
https://supervillain.readthedocs.io/
Other
0 stars 0 forks source link

Generator RNGs should be updated if ensembles are extended #143

Open evanberkowitz opened 2 months ago

evanberkowitz commented 2 months ago

Since rngs hold their own RNG, if we read + extend an ensemble we might accidentally re-use the random numbers. This could be dangerous (ie. introduce bias).

One way would be to just delete the ensemble's generator and write the latest one in there upon ensemble extension.