search

evanbowman / skyland-gba

Realtime strategy game for Gameboy Advance
Other
62 stars 3 forks source link

Invalid url parameter during high score submission #7

Open AdamCecin opened 8 months ago

AdamCecin commented 8 months ago

I get this error when attempting to submit a high score with my generated token:

[ Invalid url parameter: '' ]

at this address: https://skylandgame.io/up/?d

build hash: 9ec315d9

Release: 2024.1.29.1

evanbowman commented 8 months ago

Hello! Thanks for reporting this issue, I've seen this happen myself in the past. On my iPhone for example, the camera app QR code reader fails to correctly read long QR codes with url parameters, and truncates the url (as seen above, where there's no = character after the d url parameter).

When installing a better qr reader app, like QR Reader in iOS, I've been able to correctly scan larger QR codes. If installing a better qr reader app doesn't fix the problem, please send me your .sav file if possible, and I'll investigate!

AdamCecin commented 8 months ago

It worked! Thanks!

evanbowman commented 8 months ago

Great! Cool flag!

I could eject some diagnostic data from the QR code, making it smaller and easier to scan. But I'm hoping that the pre-installed qr scanners in phones get better, maybe things will just work.

Another thing I can do in the meantime is detect a missing url parameter in the web server and display a more helpful error message. Maybe that's what I'll do!

AdamCecin commented 8 months ago

Thanks, it’s Washington DC’s haha

an error message sounds like a great solution