search

evanchueng / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
0 stars 0 forks source link

OpenID authentication with Google Accounts fails #101

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Reported by Shawn Pearce <sop@google.com> on Tue Mar 10 15:17:14 PDT 2009
Source: JIRA GERRIT-101
Affected Version: 2.0.7

From 
http://groups.google.com/group/repo-discuss/browse_thread/thread/f7c01def834d86d
6

Clicking "Sign-in with Google Accounts" at review.source.android.com is
busted.  It comes up with

  The page you requested is invalid.

This appears to be true for all Gerrit installations using OpenID
authentication.

After much investigation today I learned that our Relying Party
implementation, dyuproject, does not conform to the OpenID 2.0 draft
specification.  When performing discovery against an XRDS service such as
Google Accounts, it fails to recognize the "server" type of service and does
not send the magic "identifier_select" claimed identity.  Last night or
sometime this morning Google Accounts must have pushed a more strict version
of their provider implementation, rejecting the requests we were sending.

Original issue reported on code.google.com by code-rev...@gtempaccount.com on 24 Sep 2009 at 7:35

GoogleCodeExporter commented 9 years ago 
Comment by Shawn Pearce <sop@google.com> on Tue Mar 10 17:06:41 PDT 2009

Fixed by switching to openid4java in https://review.source.android.com/9120

Original comment by code-rev...@gtempaccount.com on 24 Sep 2009 at 7:58

GoogleCodeExporter commented 9 years ago 
Update by Shawn Pearce <sop@google.com> on Tue Mar 10 17:06:41 PDT 2009

Fixed in version 2.0.7.

Original comment by code-rev...@gtempaccount.com on 24 Sep 2009 at 7:58

GoogleCodeExporter commented 9 years ago 
Comment by Shawn Pearce <sop@google.com> on Tue Mar 10 17:17:46 PDT 2009

Use 
http://code.google.com/p/gerrit/downloads/detail?name=gerrit-2.0.6-7-gdd95666.wa
r
(or later) if you still need OpenID authentication against Google Accounts and
Gerrit 2.0.7 hasn't been released yet.

Original comment by code-rev...@gtempaccount.com on 24 Sep 2009 at 7:58

GoogleCodeExporter commented 9 years ago

Original comment by code-rev...@gtempaccount.com on 25 Sep 2009 at 3:04