search

evanchueng / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
0 stars 0 forks source link

ability to work with patchsets as well as single changes #51

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Reported by Brian Swetland <swetland@android.com> on Wed Jan 28 16:54:35 PST 
2009
Source: JIRA GERRIT-51
Affected Version: 2.0

The kernel team is interested in having patches that are uploaded together be
logically grouped as a patchset to make it easier to keep track of all the
bits, make sure they're all reviewed, and ideally have a view that shows all
the changes in a patchset, if they've been approved, and allow them to be
submitted as a unit if so.

Being able to collect individual patches into a patchset would be nice too.

Original issue reported on code.google.com by code-rev...@gtempaccount.com on 24 Sep 2009 at 7:33

GoogleCodeExporter commented 9 years ago 
Comment by Shawn Pearce <sop@google.com> on Wed Jan 28 17:00:30 PST 2009

This issue highlights Gerrit's own unfortunate use of the term "Patch Set".

Gerrit calls a specific revision of a specific logical change a "Patch Set".

What Brian is referring to here is the more classical Git definition of a
Patch Set.

Brian Term :: Gerrit Term
    Definition...
-------------------------------------------------------

Patch        :: Change
    A single logical change to the project

Patch Set :: List of Changes?
    More than one logical change, typically related to the introduction of a
single feature

?                :: Patch Set
    An edit revision of a logical change, e.g. after incorporating review
feedback.

Original comment by code-rev...@gtempaccount.com on 24 Sep 2009 at 7:50

GoogleCodeExporter commented 9 years ago 
Comment by Brian Swetland <swetland@android.com> on Wed Jan 28 17:06:28 PST 2009

Maybe:  Change,  ChangeList or ChangeSet, RevisedChange?

I'm fine with "Change" in general.

Original comment by code-rev...@gtempaccount.com on 24 Sep 2009 at 7:50

GoogleCodeExporter commented 9 years ago

Original comment by sop+code@google.com on 24 Sep 2009 at 10:36

GoogleCodeExporter commented 9 years ago

Original comment by sop+code@google.com on 24 Sep 2009 at 10:53

GoogleCodeExporter commented 9 years ago 
We would like to have the ability to review named topic branches, consisting of 
one of more commits, and be able to view the entire topic branch, ensure each 
commit is reviewed and merge in the entire branch once ready. We also use 
multiple integration branches, but that is another feature request.

Original comment by mhanw...@gmail.com on 14 Jul 2010 at 1:10

GoogleCodeExporter commented 9 years ago 
Change I07d6c137fc9aefa8c1ee1652bf1e7bcde9d33674 adds
a topic field to the change record, and can be set at
upload time by adding it to the push command line:

  git push URL HEAD:refs/for/master/topic-name

We don't yet have a way to filter a view to show all
changes related by topic, but this is a decent start.

Original comment by sop@google.com on 15 Jul 2010 at 7:58

GoogleCodeExporter commented 9 years ago 
This looks like a great start, I love the syntax. Once there is a way to 
filter, and so view/edit all patches in a series, this would satisfy a large 
portion of what we need to be able to effectively use Gerrit. Very much looking 
forward to the next release.

Original comment by mhanw...@gmail.com on 16 Jul 2010 at 9:19

GoogleCodeExporter commented 9 years ago 
2.1.4 will also have enhanced query operators.  You can search
for "branch:master topic:topic-name is:open" to find all open
changes that are for the master/topic-name.  This is actually
already installed on a few machines.

Original comment by sop@google.com on 19 Jul 2010 at 12:59

GoogleCodeExporter commented 9 years ago

Original comment by sop@google.com on 4 Aug 2010 at 11:03

GoogleCodeExporter commented 9 years ago 
See also issue 616 now about abandon multiple
changes (and maybe submit multiple changes).

Original comment by sop@google.com on 19 Aug 2010 at 5:16

GoogleCodeExporter commented 9 years ago

Original comment by nas...@grainawi.org on 20 May 2011 at 9:55

GoogleCodeExporter commented 9 years ago 
this project is being worked on, see 
https://github.com/petefoth/gerrit-topic-reviews/wiki/

Original comment by oswald.b...@gmx.de on 8 Jun 2011 at 10:16

GoogleCodeExporter commented 9 years ago 
As mentioned in the mailing list, we have been working on this for a little 
while, and the attached file contains information about requirements and UI. We 
hope to have some code to submit for review in the near future.

Our proposals add to the existing functionality so that all the commits in a 
topic are treated as a unit for the purposes of review and approval.

Original comment by pete.fot...@gmail.com on 20 Jun 2011 at 1:19

Attachments:

GoogleCodeExporter commented 9 years ago 
this is deployed on http://codereview.qt-project.org/ now. as can be seen in 
our bug tracker 
(https://bugreports.qt.nokia.com/browse/QTQAINFRA/component/19470), it is 
afflicted with some rather serious issues, so we'll need a second iteration 
before we try upstreaming anything.

Original comment by oswald.b...@gmx.de on 10 Nov 2011 at 2:13

GoogleCodeExporter commented 9 years ago 
Re: Comment 14.
Thanks for the comment. Please can you give a bit more information?

1: Which version of the topic review functionality are you working with? Did 
you pick up the version that was pushed to review.source.gerrit.com on 31/8/11 
or have you picked up a more recent branch from the working repo on GitHub?

2: Can you tell me exactly which issues affect the topic reviews functionality? 
I have spotted the ones listed below, but are there any others I have missed?
https://bugreports.qt.nokia.com/browse/QTQAINFRA-366
https://bugreports.qt.nokia.com/browse/QTQAINFRA-351
https://bugreports.qt.nokia.com/browse/QTQAINFRA-352
https://bugreports.qt.nokia.com/browse/QTQAINFRA-375

Thanks

Original comment by pete.fot...@codethink.co.uk on 11 Nov 2011 at 7:47

GoogleCodeExporter commented 9 years ago 
hi pete,

i have no clue what exactly was used. need to query mikah or marius or look 
into the repo later.

some other [possibly] related issues:
https://bugreports.qt.nokia.com/browse/QTQAINFRA-370
https://bugreports.qt.nokia.com/browse/QTQAINFRA-372
https://bugreports.qt.nokia.com/browse/QTQAINFRA-381

some of the most serious issues result from the fact that we merged another 
rather intrusive feature (CI integration) which was developed independently. 
our beta testing of the actual implementation wasn't too thorough, either. so 
we're not blaming you in any way.
it's likely that marius will follow up with you next week or so.

Original comment by oswald.b...@gmx.de on 11 Nov 2011 at 8:38

GoogleCodeExporter commented 9 years ago 
the gerrit repository doesn't reveal what exactly was merged (it's a single 
rebased commit without attribution), and there are several fixes on top of it. 
i need to bug mika, after all.

and we have a new winner ... :}
https://bugreports.qt.nokia.com/browse/QTQAINFRA-382

Original comment by oswald.b...@gmx.de on 11 Nov 2011 at 6:26

GoogleCodeExporter commented 9 years ago 
We have a test server up here,

http://reviewtest.source.kitware.com:81

I am working on getting our topic branch with fixes on top of what Code Think 
did, but we have already encountered and fixed a few of these issues in our 
internal (and now external) testing. We have several outstanding issues too, 
but would like to upstream our changes when feasible (as well as upgrade our 
main Gerrit instance).

Original comment by marcus.h...@kitware.com on 11 Nov 2011 at 6:37

GoogleCodeExporter commented 9 years ago 
pete, the branch mika integrated had 29 commits in it and ends with a3cfb3d.

Original comment by oswald.b...@gmx.de on 14 Nov 2011 at 8:00

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I just tried out the branch Kitware is using.  
Here's a script to build it, configure a dummy project, and submit a topic 
branch for review.

The only hitch I ran into is that sometimes adding permissions to a
project doesn't work; once it gets in that state, it stays there, so
best to put the right permissions on before importing any code.
(This might just be the h2 database, I haven't tried it with a real
database yet.)

However, I've dropped the idea of using Gerrit, and am going with Gitlab 
instead.
(Gitlab is gorgeous, handles topic reviews out of the box, and offers a 
complete solution, whereas gerrit only addresses code review.)

I hear rumors that the Qt project is using a different topic review fork, don't 
knowo the details.

Original comment by daniel.r...@gmail.com on 18 Nov 2013 at 11:31

Attachments:

GoogleCodeExporter commented 9 years ago 
https://code.google.com/p/gerrit/issues/detail?id=1722 is somewhat of a dupe.
see also discussion at: 
https://plus.google.com/111049168280159033135/posts/Bhv7yXt6BhU

Original comment by bjoern.m...@gmail.com on 23 Feb 2014 at 7:54

GoogleCodeExporter commented 9 years ago 
Issue 1722 has been merged into this issue.

Original comment by jrn@google.com on 28 Feb 2014 at 6:32