search

evanchueng / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
0 stars 0 forks source link

Support for files that are modified and renamed in the same patch #593

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Affected Version:2.1.2.4-70-g2366d78

I have a patch where a file is both modified and considered renamed by git. The 
comment in the the text editor when doing "git commit" is:

#       modified:   
com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/build/ApkBu
ilder.java
#       renamed:    
com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/build/ApkBu
ilder.java -> 
com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/build/ApkBu
ilderHelper.java

And when saving the commit message it shows:
rewrite 
eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/inte
rnal/build/ApkBuilder.java (61%)
rename 
eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/inte
rnal/build/{ApkBuilder.java => ApkBuilderHelper.java} (53%)

But when I look at the patch on Gerrit, ApkBuilderHelper.java shows as 
"created" which means the side by side diff doesn't compare it to 
ApkBuilder.java.

The patch on Gerrit is visible here: 
https://review.source.android.com/#change,15221

I see that both gitx and "git diff HEAD~1" show the file as new in the diff, 
but it would be really useful to have gerrit show the file as renamed.

Original issue reported on code.google.com by x...@google.com on 10 Jun 2010 at 11:12