evanchueng / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
0 stars 0 forks source link

Problems using navigation links - Error: PR is not a function #615

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Affected Version: current master from GIT repository 
(b8ecec5d2eb19ed4cf8ab4a8b0d6a078e7d13234)

What steps will reproduce the problem?
1. Using various navigation links on changes (I've seen it on entering change 
from changes list and leaving diff view with "up to change" link). The issue is 
non-deterministic and reloading the page in browser usually helps.

What is the expected output? What do you see instead?
The page only displays "loading" for a short time and does not load selected 
link.

Please provide any additional information below.
Sample entry from Firefox's error console:

Error: PR is not a function
Source File: 
https://MY_SERVER_NAME/review/gerrit/4285285E643A458DEA18B224C9083FED.cache.html
Line: 4174

Mentioned line looks like this:
function E7(a){var b;b=Ty(a.k);if(!a.c&&b){a.c=true}else if(a.c&&!b){return 
false}a.i=DIc(mIc((new Date).getTime()));switch(a.h){case 
0:a.g==0&&N7(a.f);while(a.g<a.d.d){O7(a.f,xid(a.d,a.g));if(++a.g%10==0&&DIc(mIc(
(new Date).getTime()))-a.i>200){H7(a);return 
true}}PR(a.j,a.f);a.f=null;a.h=1;a.g=0;case 
1:while(a.g<a.d.d){Q7(a.j,a.g+1);if(++a.g%50==0&&DIc(mIc((new 
Date).getTime()))-a.i>200){H7(a);return true}}H7(a);G7(a);}return false}

Original issue reported on code.google.com by Rafal.Kr...@gmail.com on 30 Jun 2010 at 2:13

GoogleCodeExporter commented 9 years ago
Bug caused by prettify occupying the same JavaScript
namespace as GWT obfuscated code.  We changed some
of the UI and some of the GWT obfuscated versions
suddenly started needing to use the name 'PR'.

Fixed by I30523854067eb33250810e9d2f7e23b4c691541f

Original comment by sop@google.com on 13 Jul 2010 at 3:14

GoogleCodeExporter commented 9 years ago

Original comment by sop@google.com on 28 Mar 2012 at 2:55