search

evanchueng / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
0 stars 0 forks source link

Possibility to remove trailing whitespaces on server side #620

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Add a possibility to remove trailing whitespaces on server side

Original issue reported on code.google.com by annu...@gmail.com on 6 Jul 2010 at 8:47

GoogleCodeExporter commented 9 years ago 
The problem with this is we have edit the commit, which
changes the commit SHA-1.  If you have a local branch
that is pointing at the change, it won't be correct after
the server has made the edit.

I guess its no worse than the reviewer doing a cherry-pick
and uploading their own replacement after using rebase with
the --whitespace=fix option.  If we send out a notification
that the whitespace was trimmed, it just saves the reviewer
some steps to clean up an otherwise fine patch before they
submit it to the repository.

Original comment by sop@google.com on 13 Jul 2010 at 2:42