evanchueng / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
0 stars 0 forks source link

Request for tags "Gerrit-Owner" and "Gerrit-Reviewer" in generated emails #623

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Background: I want to be able to filter two particular types of 
gerrit-generated emails using Gmail filters. (1) Any mail having to do with a 
change I created. (2) Any mail that is related to a change I have been asked to 
review.

I don't think there's a way to reliably filter those messages right now, but 
with the addition of a couple new tags, I think there could be.

Exactly one "Gerrit-Owner: user@example.com" line would get added to every 
message. This would contain the email address of the owner of the change.

One or more "Gerrit-Reviewer: user@example.com" lines would get added to every 
message having to do with a change that has assigned reviewers, one per 
reviewer.

So, any messages for changes I make would get tagged "Gerrit-Owner: 
danfuzz@android.com" and any messages for changes I've been asked to review 
would get tagged "Gerrit-Reviewer: danfuzz@android.com". Both are super-easy to 
reliably filter for.

Thanks for your consideration!

Original issue reported on code.google.com by danfuzz....@gmail.com on 7 Jul 2010 at 11:21

GoogleCodeExporter commented 9 years ago
Change https://review.source.android.com/15761 does this.

But I think I need to ask... if you are filtering like
this, why are you getting so much email from Gerrit?
Did you sign up for all notifications on a project, but
don't really want them?  Or are you just trying to get
a GMail label to appear in your inbox to denote special
messages that you need to react to, vs. other emails?

Original comment by sop@google.com on 13 Jul 2010 at 3:10

GoogleCodeExporter commented 9 years ago
Thanks for the quick turnaround!

In answer to your question, here's a bit more detail:

Yes, I have whole project notifications for a few relavent projects, e.g. I 
want to see everything happening in the dalvik and libcore projects (and a 
couple more). I filter most gerrit-related mail into a "changelog" label, which 
I go through once a day or so.

I also have a "code review" label, which is meant for messages that demand a 
more immediate reaction from me, such as when I'm asked to do a review or when 
someone comments on one of my patches.

Until now, I couldn't get Gmail to reliably distinguish messages in the former 
and latter categories, and so some important messages would slip through the 
cracks (get licked up by the wrong label), which meant that I couldn't simply 
monitor "code review" for unread messages if I wanted to be maximally reactive.

Original comment by danfu...@gmail.com on 13 Jul 2010 at 3:55

GoogleCodeExporter commented 9 years ago
Well, its live on review.source.android.com now.

:-)

Original comment by sop@google.com on 13 Jul 2010 at 4:55

GoogleCodeExporter commented 9 years ago

Original comment by sop@google.com on 28 Mar 2012 at 2:55