Keyboard Shortcuts don't work 100% in recent WebKit browsers

[GoogleCodeExporter]

Original discussion from the mailing list: 
http://groups.google.com/group/repo-discuss/browse_thread/thread/2d9e87f4beeb3f8
b/fbc18ce13f5ef7cb#fbc18ce13f5ef7cb

Affected Version: 2.1.3

Keyboard shortcuts don't work 100% in Google Chrome (or Safari).  They all seem 
to work fine in 
Firefox and IE. 
The shortcuts which don't work properly in Google Chrome are (Tested 
in Ubuntu 10.04 and Windows XP): 
<Ctrl> + d : discard draft comment, it adds a bookmark instead. 
<Ctrl> + s : save draft comment, it tries to "Save File" instead. 
c : Create a new inline comment.  It does work, but when the draft 
textarea box appears it has the "c" character in it. 

I have attached a patch that partially gets Google Chrome working for <ctrl> +s 
and d, but after pressing <ctrl> + s the j and k keyboard shortcuts stop 
working.  After <ctrl> + d it works ok.

So, not entirely sure what I missed.  Maybe someone else knows why Google 
Chrome ends up in that state.

Original issue reported on code.google.com by joel.pea...@gmail.com on 28 Jul 2010 at 6:50

Attachments:

• 0001-Get-Ctrl-s-Ctrl-d-kinda-working-in-Google-Chrome.patch

[GoogleCodeExporter]

Issue 431 has been merged into this issue.

Original comment by sop@google.com on 19 Aug 2010 at 10:24

[GoogleCodeExporter]

Fixed by I08732be288f1149073d85bc5e09ab4cfb6547f8f

Original comment by sop@google.com on 20 Aug 2010 at 12:21

• Changed state: Fixed
• Added labels: FixedIn-2.1.4.1

[GoogleCodeExporter]

Original comment by sop@google.com on 20 Aug 2010 at 2:49

• Added labels: FixedIn-2.1.5
• Removed labels: FixedIn-2.1.4.1

[GoogleCodeExporter]

Original comment by sop@google.com on 28 Mar 2012 at 2:55

• Changed state: Released