issue with RRule 2.2.0 - Githubissues

evancohen / smart-mirror

The fairest of them all. A DIY voice controlled smart mirror with IoT integration.

http://smart-mirror.io

2.79k stars 694 forks source link

issue with RRule 2.2.0 #615

Closed sdetweil closed 7 years ago

sdetweil commented 7 years ago

unable to process calendar events,

var RRule = require('rrule').RRule

missing

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Your Environment

Environment name and version (e.g. Raspberry Pi 3, node.js 5.4):
Operating System and version (e.g. Raspbian, Ubuntu, OSX):

justbill2020 commented 7 years ago

this is an issue with the underlying dependency RRule... I submitted an issue to them. https://github.com/jakubroztocil/rrule/issues/166

you cannot "require" on client side JS... and rrule is imported on line 92 of index.html as it always has been.

https://github.com/evancohen/smart-mirror/blob/dev/index.html#L92

sdetweil commented 7 years ago

cool.. the require works however

justbill2020 commented 7 years ago

forced rrule 2.1.0 in bower.json on dev and master as of tonight... we'll update it to latest release after they respond to my issue and i confirm it is fixed... running npm install will roll back to previous release...