search

evancohen / sonus

:speech_balloon: /so.nus/ STT (speech to text) for Node with offline hotword detection
MIT License
619 stars 79 forks source link

WIP: Add tests for future refactoring #53

Open joyarzun opened 7 years ago

joyarzun commented 7 years ago

Hi there. I want to add tests for future refactoring and not breaking anything. The idea is refactoring to isolate the recognizer code and be able to add others streaming services. This is a WIP to know whether it's the right way or not. It's my first time making mocks of Stream. What do you think?

evancohen commented 7 years ago

Sounds like a good idea to me! @ashishsc?

ashishsc commented 7 years ago

lgttm ! thanks @joyarzun

evancohen commented 7 years ago

Jumped the gun there a little bit, pretty sure this is work in progress. You must really want tests ;)

ashishsc commented 7 years ago

woops. I meant to say lgtm to keep going forward = )