search

evancz / elm-architecture-tutorial

How to create modular Elm code that scales nicely with your app
https://guide.elm-lang.org/
BSD 3-Clause "New" or "Revised" License
4.17k stars 738 forks source link

Error in tutorial text code example #105

Closed BryanJBryce closed 4 years ago

BryanJBryce commented 7 years ago

I'm not sure if this is the right place to leave this, if the actual tutorial text was hosted I'd comment there, but the tutorial text has either a misleading or incorrect code example from 05-Http: 

decodeGifUrl : Json.Decoder String
decodeGifUrl =
  Json.at ["data", "image_url"] Json.string

In order to match the accompanying code in this repo and in the online example: Json.Decoder should be Decode.Decoder Json.at should be Decode.at Json.string should be Decode.String

process-bot commented 7 years ago

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

evancz commented 4 years ago

The examples have been updated as new releases come out. It looks like the JSON example code matches exactly in the latest version. Sorry for the trouble with the older version!