search

evancz / elm-todomvc

The TodoMVC app written in Elm, nice example for beginners.
http://evancz.github.io/elm-todomvc/
BSD 3-Clause "New" or "Revised" License
1.22k stars 329 forks source link

deploy to heroku don't work #37

Closed zzz6519003 closed 8 years ago

zzz6519003 commented 8 years ago 
    No argument was given for the port named 'getStorage' with type:

        Maybe.Maybe Todo.Model

:+1:

evancz commented 8 years ago

Can you find the PR that added the button and cc the person that added it?

If we can't get ahold of this person, can you open a PR to remove the button?

zzz6519003 commented 8 years ago

yes, sir!

use "git blame" magic

cc @srid

evancz commented 8 years ago

Cool, I think from here the process should be: let's do the PR to remove the button. If @srid can fix it, he can do a new PR that adds it back in a working way.

srid commented 8 years ago

Cool, I think from here the process should be: let's do the PR to remove the button.

I think there should be a few days time before doing the removal, so it gives me an opportunity to respond.

srid commented 8 years ago

@zzz6519003 - Your title is inaccurate. Deploy to Heroku works (i.e, succeeds) - however the app is emitting the error during runtime (i.e., when accessed from browser):

Port Error:

    No argument was given for the port named 'getStorage' with type:

        Maybe.Maybe Todo.Model

    You need to provide an initial value!

    Find out more about ports here <http://elm-lang.org/learn/Ports.elm>

Open the developer console for more details.
zzz6519003 commented 8 years ago

Cool, I think from here the process should be: let the app not emit the error during runtime