Tracking the entry that is being edited should live on the Model and not Entry

evancz / elm-todomvc

The TodoMVC app written in Elm, nice example for beginners.

http://evancz.github.io/elm-todomvc/

BSD 3-Clause "New" or "Revised" License

1.22k stars 329 forks source link

Tracking the entry that is being edited should live on the Model and not Entry #59

Open mrozbarry opened 7 years ago

mrozbarry commented 7 years ago

It looks like all the base are covered, but it is theoretically possible for two entries to be marked as editing = True.

Having something like editingEntryId : Maybe String would eliminate that possibility, and be more explicit. It does mean passing around more information into the entry views, though. I also don't know if this is technically any more correct.