Doc typo: missing a `s` in the `oneOf` example

evancz / url-parser

Parse URLs into nicely structured data

http://package.elm-lang.org/packages/evancz/url-parser/latest/

BSD 3-Clause "New" or "Revised" License

114 stars 29 forks source link

Doc typo: missing a `s` in the `oneOf` example #47

Closed magopian closed 6 years ago

magopian commented 7 years ago

I believe the line at https://github.com/evancz/url-parser/blob/7c67e7f95a49c9a0e4b51b91d4fd05169dacc680/src/UrlParser.elm#L208

Should instead read

, map Comment (s "user" </> string </> s "comments" </> int)

(see the additional s before comments).

process-bot commented 7 years ago

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

evancz commented 6 years ago

Looks like it is missing an s! I have since redone the examples for the next iteration of this API and that mistake did not make it into the new oneOf docs.