search

evanderkoogh / otel-cf-workers

An OpenTelemetry compatible library for instrumenting and exporting traces for Cloudflare Workers
BSD 3-Clause "New" or "Revised" License
208 stars 39 forks source link

Add back service binding fetch instrumentation #135

Closed DaniFoldi closed 1 month ago

DaniFoldi commented 2 months ago

Ref #116 , #134

What this PR solves / how to test:

When we added the fix for the JSRPC runtime change, we disabled their caller-side instrumentation completely. This PR adds back the same instrumentation that we had before. For anyone reading, we still need to figure out a non-breaking way to instrument RPC-style function calls without interfering with user code.

cdloh commented 1 month ago

@jahands @DaniFoldi apologies if I'm misunderstanding this MR but doesn't this specifically remove service binding fetch instrumentation?

I had to revert this MR and add the functionality back in for spans to cross env.BINDING_NAME.fetch in my worker.