Allow custom resource attributes - Githubissues

evanderkoogh / otel-cf-workers

An OpenTelemetry compatible library for instrumenting and exporting traces for Cloudflare Workers

BSD 3-Clause "New" or "Revised" License

249 stars 51 forks source link

Allow custom resource attributes #145

Open jasonkuhrt opened 6 months ago

jasonkuhrt commented 6 months ago

Hey, here's the situation:

We're sending traces to Grafana Tempo
We want to use its deployment.environment resource attribute to split traces between stages
- https://grafana.com/docs/grafana-cloud/monitor-applications/application-observability/manual/inventory/#deployment-environment
This requires interacting with the resource concept https://opentelemetry.io/docs/languages/js/resources/
At this point I do not know what to do with this library. I need to create/augment the resource with the attribute deployment.environment.

jasonkuhrt commented 6 months ago

Ah found https://github.com/evanderkoogh/otel-cf-workers/blob/af75f359efc279582990fb1d8c9245ed75069597/src/sdk.ts#L53

jasonkuhrt commented 6 months ago

Ok so I think this is a feature request from our side to be able to add resource attributes, e.g.:

CleanShot 2024-05-31 at 09 06 57@2x

jasonkuhrt commented 6 months ago

My current local patch:

CleanShot 2024-05-31 at 09 31 35@2x

oxcafedead commented 6 months ago

@jasonkuhrt can you please take a look - maybe my PR is about the same issue? - https://github.com/evanderkoogh/otel-cf-workers/pull/127

jasonkuhrt commented 6 months ago

@oxcafedead that would be perfect yep!