Closed DaniFoldi closed 3 months ago
Hi :wave:,
I've noticed some small inconsistencies with the KV instrumentation; all but get and getWithMetadata contain a kv. prefix for all attributes, and they are missing here: https://github.com/evanderkoogh/otel-cf-workers/blob/18fd741142bab45178ac6f9032d8a6b646a03597/src/instrumentation/kv.ts#L12-L29
get
getWithMetadata
kv.
Additionally, list and getWithMetadata now return a cache status (WIP docs: https://maddy-make-kv-product-tile.cloudflare-docs-7ou.pages.dev/kv/platform/observability/, types: https://workers-types.pages.dev/#KVNamespaceListResult.cacheStatus ). It could be nice to replace all calls to get with getWithMetadata, return only the value of get was requested, but keep the cache attribute for telemetry.
list
Hi :wave:,
I've noticed some small inconsistencies with the KV instrumentation; all but
getandgetWithMetadatacontain akv.prefix for all attributes, and they are missing here: https://github.com/evanderkoogh/otel-cf-workers/blob/18fd741142bab45178ac6f9032d8a6b646a03597/src/instrumentation/kv.ts#L12-L29Additionally,
listandgetWithMetadatanow return a cache status (WIP docs: https://maddy-make-kv-product-tile.cloudflare-docs-7ou.pages.dev/kv/platform/observability/, types: https://workers-types.pages.dev/#KVNamespaceListResult.cacheStatus ). It could be nice to replace all calls togetwithgetWithMetadata, return only the value ofgetwas requested, but keep the cache attribute for telemetry.