Closed DaniFoldi closed 11 months ago
I certainly wouldn't worry too much about making all the extra attributes perfect. It looks great as it is right now and if there are circumstances where we can improve some of those extra attributes, people will ask for it.
Let me know when you have had a chance to test it some more if you want. Happy to merge it as is..
This PR implements instrumentation for Analytics Engine datasets. Couple of questions:
.toString
. Any recommendatons for that, if nothing else we can use aTextDecoder
to get some log-friendly text out of it.Also this PR needs some testing before I'm confident merging it.