search

evanderkoogh / otel-cf-workers

An OpenTelemetry compatible library for instrumenting and exporting traces for Cloudflare Workers
BSD 3-Clause "New" or "Revised" License
208 stars 39 forks source link

[fix] support hrtime tuple as TimeInput instead of throwing #69

Closed Schniz closed 8 months ago

Schniz commented 8 months ago

when providing a TimeInput that is , this library crashes. However, it is a totally safe input and it's easy to normalize: we just do nothing.

This is happening when using Effect.ts (https://effect.website) with this library as an exporter.

Schniz commented 8 months ago

I don't see any tests for this, but I tested it locally using pnpm patch-package :blob_smile:

evanderkoogh commented 8 months ago

That is a decent 'Doh!' :D

Thanks for that!