search

evanderkoogh / otel-cf-workers

An OpenTelemetry compatible library for instrumenting and exporting traces for Cloudflare Workers
BSD 3-Clause "New" or "Revised" License
208 stars 39 forks source link

Fix span.end() call for scheduled tracing #72

Closed Ankcorn closed 8 months ago

Ankcorn commented 8 months ago

I noticed span.end() was only being called in the case of failures so we where not getting any data for scheduled invocations.

I also bumped the dependencies oltp-http, exporter-base and transformer to 0.44.0 so the peer deps of @opentelemetry/api are in the correct version range and and I can install packages without peer dep warnings

evanderkoogh commented 8 months ago

Doh! Great catch. And thanks for the bump in the exporter versions. They weren’t released yet when I upgraded the rest of the versions. Been meaning to check if they had been released!

Ankcorn commented 8 months ago

Thanks for merging @evanderkoogh

Hopefully my first contribution of many :)

DaniFoldi commented 8 months ago

Hey @Ankcorn,

Thanks for noticing and fixing!

evanderkoogh commented 8 months ago

My pleasure! And I hope exactly the same 😃