search

evanderkoogh / otel-cf-workers

An OpenTelemetry compatible library for instrumenting and exporting traces for Cloudflare Workers
BSD 3-Clause "New" or "Revised" License
208 stars 39 forks source link

cache.hit attribute is the opposite #78

Closed beanow-at-crabnebula closed 4 months ago

beanow-at-crabnebula commented 6 months ago

https://github.com/evanderkoogh/otel-cf-workers/blob/2d370cb9098a9066da3ba2b3102d6f29e5c99c31/src/instrumentation/cache.ts#L25C45-L25C45

This seems incorrect. I see cache.hit=true on cache misses and vice versa :]