Closed AaronO closed 2 weeks ago
I am so sorry it took 8 months to get this PR merged.. I have had to set away from maintaining the library for more than a year due to family circumstances and while Jacob and Dani did a great job in keeping things going in the meantime they might not have felt comfortable merging this PR.
Thanks again for the PR. I (and a bunch of people who have asked for D1 support) greatly appreciate it!
@evanderkoogh No problem, life happens, been in a similar boat, hope things are better !
I think there were a few other things I wanted to instrument when I did this a while back, I'll take another look, wasn't 100% sure if this lib was still being developed.
Well it was in hiatus mode with some people looking to make sure it kept running, but without the time to really develop it. But I am back in business and this is now part of my job at Honeycomb, so will have a lot more time for it..
This provides a first pass implementation of D1 support, I'll do some testing and tweaking tomorrow
A few notes:
.batch()
requires peaking into D1 internalsfirst
,all
, ...) instead of grouping them under query/exec_send
but that's abstraction breaking, so I instead stuck to the publicly exposed TS APIsExample
Here's some traces generated by this PR in an otel viewer: