search

evandrocoan / MultiModServer

It is a Multi-Mod plugin's configurations for Amx Mod X - https://forums.alliedmods.net/showthread.php?t=273018
GNU General Public License v3.0
17 stars 17 forks source link

Create an optimum time for the vote starting at map end #20

Closed mo0nsniper closed 7 years ago

mo0nsniper commented 7 years ago

Hello,

I'm having an issue with my configuration. I want the galileo map vote to show up in less than 4 minutes to the end of map. But now it shows up at approx 7:30 minutes. I have set gal_endofmapvote_start 1 in my cfg.

Here is my galileo.cfg and other settings. Also I am using ReHLDS as an engine.:

http://pastebin.com/EBVJfkYS

status
hostname:  CS.MIEZ.ro | STEAM Only |   NOVEMBER Update
version :  48/1.1.2.7/Stdio 921 secure  (10)
tcp/ip  :  94.176.2.150:27015
map     :  fy_cluj at: 0 x, 0 y, 0 z
players :  0 active (26 max)

#      name userid uniqueid frag time ping loss adr
0 users
    version
Protocol version 48
Exe version 1.1.2.7/Stdio (cstrike)
Exe build: 21:15:26 Oct 19 2016 (921)
ReHLDS API version 2.13
    meta list
Currently loaded plugins:
      description      stat pend  file              vers      src   load  unlod
 [ 1] SafeNameAndChat  RUN   -    SafeNameAndChat.  v1.0      ini   ANY   ANY
 [ 2] AMX Mod X        RUN   -    amxmodx_mm_i386.  v1.8.3-d  ini   Start ANY
 [ 3] Rechecker        RUN   -    rechecker_mm_i38  v2.0      ini   Chlvl ANY
 [ 4] WHBlocker        RUN   -    whblocker_mm_i38  v1.5.626  ini   Chlvl ANY
 [ 5] GeoIP            RUN   -    geoip_amxx_i386.  v1.8.3-d  pl2   ANY   ANY
 [ 6] hackdetector     RUN   -    hackdetector_amx  v0.15.30  pl2   ANY   ANY
 [ 7] CStrike          RUN   -    cstrike_amxx_i38  v1.8.3-d  pl2   ANY   ANY
 [ 8] FakeMeta         RUN   -    fakemeta_amxx_i3  v1.8.3-d  pl2   ANY   ANY
 [ 9] Ham Sandwich     RUN   -    hamsandwich_amxx  v1.8.3-d  pl2   ANY   ANY
 [10] Engine           RUN   -    engine_amxx_i386  v1.8.3-d  pl2   ANY   ANY
 [11] MySQL            RUN   -    mysql_amxx_i386.  v1.8.3-d  pl2   ANY   ANY
 [12] CSX              RUN   -    csx_amxx_i386.so  v1.8.3-d  pl2   ANY   ANY
 [13] Fun              RUN   -    fun_amxx_i386.so  v1.8.3-d  pl2   ANY   ANY
13 plugins, 13 running
    amxx list
Currently loaded plugins:
       name                    version     author            file             status
 [  1] Aliases checker         1.0.3       kanagava          alias_detector.  running
 [  2] TimePass-AC             9.0         Challenge         TP_aim.amxx      running
 [  3] Advanced Bans           0.8.1       Exolent & mo0n_s  advanced_bans.a  running
 [  4] Admin Base              1.8.3-dev+  AMXX Dev Team     admin.amxx       running
 [  5] Admin Commands          1.8.3-dev+  AMXX Dev Team     admincmd.amxx    running
 [  6] Admin Help              1.8.3-dev+  AMXX Dev Team     adminhelp.amxx   running
 [  7] Slots Reservation       1.8.3-dev+  AMXX Dev Team     adminslots.amxx  running
 [  8] Multi-Lingual System    1.8.3-dev+  AMXX Dev Team     multilingual.am  running
 [  9] Menus Front-End         1.8.3-dev+  AMXX Dev Team     menufront.amxx   running
 [ 10] Commands Menu           1.8.3-dev+  AMXX Dev Team     cmdmenu.amxx     running
 [ 11] Players Menu            1.8.2       AMXX Dev Team     plmenu.amxx      running
 [ 12] Maps Menu               1.8.3-dev+  AMXX Dev Team     mapsmenu.amxx    running
 [ 13] Plugin Menu             1.8.3-dev+  AMXX Dev Team     pluginmenu.amxx  running
 [ 14] AMXX Gag                1.5.0       xPaw & mo0n_snip  amx_gag.amxx     running
 [ 15] Admin Chat              1.8.3-dev+  AMXX Dev Team     adminchat.amxx   running
 [ 16] Anti Flood              1.8.3-dev+  AMXX Dev Team     antiflood.amxx   running
 [ 17] Scrolling Message       1.8.3-dev+  AMXX Dev Team     scrollmsg.amxx   running
 [ 18] Info. Messages          1.8.3-dev+  AMXX Dev Team     imessage.amxx    running
 [ 19] Admin Votes             1.8.2       AMXX Dev Team     adminvote.amxx   running
 [ 20] Galileo                 v3.2.4-248  Brad Jones/Addon  galileo.amxx     running
 [ 21] TimeLeft                1.8.3-dev+  AMXX Dev Team     timeleft.amxx    running
 [ 22] Pause Plugins           1.8.3-dev+  AMXX Dev Team     pausecfg.amxx    running
 [ 23] Stats Configuration     1.8.3-dev+  AMXX Dev Team     statscfg.amxx    running
 [ 24] Restrict Weapons        1.8.3-dev+  AMXX Dev Team     restmenu.amxx    running
 [ 25] StatsX                  1.8.3-dev+  AMXX Dev Team     statsx.amxx      running
 [ 26] CS Stats Logging        1.8.3-dev+  AMXX Dev Team     stats_logging.a  running
 [ 27] AMX Client Exec         0.03        v3x               amx_exec.amxx    running
 [ 28] Admin Spectator ESP     1.4_beta    KoST&mo0n_sniper  admin_spec_esp.  running
 [ 29] Autoresponder/Advertis  0.5         MaximusBrood      ad_manager.amxx  running
 [ 30] All Chat                1.1         Ian Cammarata     allchat.amxx     running
 [ 31] MIEZ - Reset Score      1.0         Silenttt&mo0n_sn  resetscore.amxx  running
 [ 32] Auto Demo Recorder      1.5         IzI&mo0n_sniper   amx_demorecorde  running
 [ 33] MIEZ - amx_ss           1.0         Askhanar & mo0n_  amx_ss.amxx      running
 [ 34] AMX Blind               1           snoopy            amx_blind.amxx   running
 [ 35] MIEZ - BHPK             2.7         Lev & mo0n_snipe  amx_hpk.amxx     running
 [ 36] MIEZ - admin_who        1.0         mo0n_sniper&eXtr  admin_who.amxx   running
 [ 37] AMX Transfer            1.2         Deviance          amx_transfer.am  running
 [ 38] Flash Remote Control    12.0        OT                flashbang_remot  running
 [ 39] c4 timer                1.1         cheap_suit        c4timer.amxx     running
 [ 40] Play or Be Kicked       1.5.243     Brad Jones & mo0  pbk.amxx         running
 [ 41] Last Maps Time          0.0.1       Exolent           last_maps_time.  running
41 plugins, 41 running

Feature request

make a CVAR that includes the 2 minutes default voting and the extra 4 minutes so it's easier to configure without modifying the code. https://github.com/evandrocoan/Galileo/issues/20#issuecomment-257863093

evandrocoan commented 7 years ago

Hi, if you want to the voting to start for sure with less than 4 minutes:

1, The easy way is to disable the gal_endofmapvote_start, i.e., set is to 0.

// Indicates whether there should be created a 4 minutes range before
// the last 2 minutes to detect a round start and to give time about 20
// seconds to buy weapons after the round to start and before the map
// voting to start.
// 0 - disabled this feature
// 1 - enable this feature
gal_endofmapvote_start 0

2, You could change the range from 500 seconds to 240 seconds: https://github.com/evandrocoan/Galileo/blob/4f899bedc94a8279decd3f8dbd9187d0c69686ac/scripting/galileo.sma#L427-L432

/**
 * The macro 'VOTE_ROUND_START_DETECTION_DELAYED(0)' use this second intervals. The default time
 * interval range is 4 minutes.
 */
#define VOTE_ROUND_START_MIN_DELAY 500
#define VOTE_ROUND_START_MAX_DELAY START_VOTEMAP_MIN_TIME
mo0nsniper commented 7 years ago

Thank you for the reply. I'll try setting VOTE_ROUND_START_MIN_DELAY to 240 because I like the option gal_endofmapvote_start for having the vote at the start of the round.

But from where comes the 7.5 minutes delay because 500 seconds + 2 minutes should be 6 minutes maximum?

evandrocoan commented 7 years ago

Actually there is a error, I say 4 minutes but it is 5.81 minutes. It is fixed for the next version: 3a38351

mo0nsniper commented 7 years ago

Nice, thanks for the fix.

Maybe you could make a CVAR that includes the 2 minutes default voting and the extra 4 minutes so it's easier to configure without modifying the code.

evandrocoan commented 7 years ago

Yeah, but I need to take care with another things first before allowing free configuration by cvars.

  1. https://github.com/evandrocoan/Galileo/issues/8 _ Limit the maximum voting time start

Because depending on the cvars gal_runoff_duration and gal_vote_duration + some internal delays, the voting must to start with some antecedence, otherwise the map will end before the voting is finished.

evandrocoan commented 7 years ago

Feature request: make a CVAR that includes the 2 minutes default voting and the extra 4 minutes so it's easier to configure without modifying the code.

By above commit, what automatically created a way to calculate the optimum minimum time and allowing to choose on which round to start the voting. Now just last to implement this feature for the cvars mp_maxrounds/wins and mp_fraglimit scheduled on the issue:

  1. https://github.com/evandrocoan/Galileo/issues/38 New end on round voting algorithm