evandrocoan / MultiModServer

It is a Multi-Mod plugin's configurations for Amx Mod X - https://forums.alliedmods.net/showthread.php?t=273018
GNU General Public License v3.0
19 stars 17 forks source link

gal_nextmap_change support for amx_votemap #22

Closed mo0nsniper closed 7 years ago

mo0nsniper commented 8 years ago

Hello Evandro,

I would really like your help in implementing the following feature for the galileo plugin. What I want to do is have the galileo plugin voting also take into account admin voting with amx_votemap command. So when there are admins on the server they can make manual votes,

For example: If the gal_nextmap_change feature is enabled and an admin uses the amx_votemap command, the nextmap will be set by the amx_votemap result and skip the galileo automatic vote. So an admin can make a custom vote for the nextmap and if he chooses No to changing the map after the voting finishes galileo would not start another vote and would also change to the choosen map after finnishing the last round.

This would be a nice feature in my oppinion.

mo0nsniper commented 7 years ago

Therefore it will now only control how many players must there be on the server to allow the round finish feature.

Yes, that sounds better as it is more clear.

I will test in about an hour the new version.

evandrocoan commented 7 years ago

On build v4.0.0-433, I just fixed the bug on the gal_endonround_msg and its HUD control migration to the cvar gal_sounds_hud.

I also added a new feature:

  1. Removed the restriction from the cvar gal_endonround_msg requiring the cvar gal_nextmap_change to be enabled.
mo0nsniper commented 7 years ago

Updated to "gal_version" is "v4.0.0-435" set gal_endonround_msg to 1 The nexmap changes correctly. But the message about nextmap didn't show this time.

I don't understand what I have to set gal_endonround_msg and gal_sounds_hud to show only a chat message without HUD message.

evandrocoan commented 7 years ago

But the message about nextmap didn't show this time.

The message will not show because galileo is not blocking the round end, as there is only player at the server (or the gal_endonround_msg player number). That message you are used to see is only displayed when galileo is blocking the map change, to allow the round to finish. However as there is only one player on the server, we are not blocking the map change when the time expires. Then the message is not show.

mo0nsniper commented 7 years ago

I understand now. Thanks.

evandrocoan commented 7 years ago

You are welcome. Now, is there something more missing? If not we could close this issue.

mo0nsniper commented 7 years ago

Thank you for implementing this. It can be closed so there are 0 open issues :)

I'll close the issue and then will update the plugin also on my main server. If there is any problem I'll post again.

evandrocoan commented 7 years ago

You are welcome.

And those crashes what were happening the other day, they happened again? Now I am improving the feature gal_srv_move_cursor:

// Move the cursor on map series, because they are continuations as to
// afrikakorps1 and 2, respectively.
//
// For example, if on you server you got installed the following maps:
// de_dust, de_dust2, de_dust3, de_dust4, de_inferno, de_chateal and de_nuke.
//
// This feature will take your map cycle as:
//
//     de_dust
//     de_inferno
//     de_chateal
//     de_dust2
//     de_nuke
//
// And will understand/load it as being:
//
//     de_dust
//     de_dust2
//     de_dust3
//     de_dust4
//     de_inferno
//     de_chateal
//     de_dust2
//     de_nuke
//
// Or:
//
//     de_dust
//     de_dust2
//     de_dust3
//     de_dust4
//     de_inferno
//     de_chateal
//     de_dust2
//     de_dust3
//     de_dust4
//     de_nuke
//
// If the next map in the map cycle after afrikakorps1 is sc_another,
// it will set the next map to afrikakorps2, and afrikakorps3.
//
// The flags 1 and 2 are additive and the flag 4 and 8 are exclusive.
// A value of 0 will disable this feature.
//
//  1 - to load only the first map series it found
//  2 - to load also the other the map series it found
//  4 - only to load a map series if it implicitly starting at 1, as `de_dust` and `de_nuke`
//  8 - only to load a map series if it explicitly starting on 1, as `de_dust1` and `de_nuke1`
//
// For example, if you want to use the options 1 and 2, use 1 + 2:
// gal_srv_move_cursor 3
//
// Instead of:
// gal_srv_move_cursor 0
gal_srv_move_cursor 11
mo0nsniper commented 7 years ago

No crashes since yesterday so I would say they are fixed.