search

evandrocoan / MultiModServer

It is a Multi-Mod plugin's configurations for Amx Mod X - https://forums.alliedmods.net/showthread.php?t=273018
GNU General Public License v3.0
19 stars 17 forks source link

New end on round voting algorithm #38

Closed evandrocoan closed 7 years ago

evandrocoan commented 7 years ago

New end on round voting algorithm

The current algorithm uses a fixed value as 400 seconds before the last 2:30 minutes.

Now implement a heuristic which counts every end round, how much time the round took and how much time remains to the end of map. In base with it, calculate the correct round to start the voting. Also add a fail safe to block map change until the voting is completed, whether it is by round, frags or time.

Also, to perform the voting exactly when the map is about the end considering the shifts by the voting maps times related on:

  1. https://github.com/evandrocoan/Galileo/issues/20 Vote starting at 7 minutes before map end

  2. https://github.com/evandrocoan/Galileo/issues/8 _ Limit the maximum voting time start

  3. [x] Implement the cvar gal_endofmapvote_start's feature heuristics for mp_fraglimit and mp_maxrounds/wins.

  4. [ ] ~May be also to detect map time anomalies as the time limit being set to and the time left changes from 10 to 1 minute. This is due the new fail safe implemented on:~

    • 55a675018dfecb7398b0e6773759b96a9a7a1f69 Improved the voting end fail safe code structure.

Now if the time limit is abnormally set, the map will never change because the voting will never start and its state set to over. Then we need to implement a clever end voting fail safe:

  1. [ ] ~To auto set the voting as over when there is not enough time to perform a full voting, or just to start the voting right away.~
  2. [ ] ~To start the voting anyways when there is not enough time for a full voting, but just to perform the first voting part not allowing the runoff.~
ish12321 commented 7 years ago

Is it done ? ., What about in end by rounds make the round doesn't end before the voting has completely not ended ? If that's possible it would make it very better

evandrocoan commented 7 years ago

When you are using rounds, the voting should start some rounds before the map change, so there should be enough time to the voting to finish. But I will consider adding a fail safe to block map change until the voting is completed.

It is a open issue, then I is not implemented yet. See:

  1. Mastering Issues _ https://guides.github.com/features/issues/
ish12321 commented 7 years ago

Please finish it asap as it will solve my issue #36

ish12321 commented 7 years ago

Can you atleast do this and release a working small release Too important Please