Fix #3 - Avoid invoking plantuml_connection for invalid server

evandrocoan / PlantUmlDiagrams

A fork from https://github.com/jvantuyl/sublime_diagram_plugin package for Sublime Text, to render diagrams in your source code

Other

38 stars 10 forks source link

Fix #3 - Avoid invoking plantuml_connection for invalid server #9

Closed xenofanes9 closed 5 years ago

xenofanes9 commented 5 years ago

Avoid invoking plantuml_connection and generating content to send to server if 'plantuml_server' set to invalid server

For cases where specified server won't work (i.e. "plantuml_server": ""), avoids generating server request.

xenofanes9 commented 5 years ago

Change does a simple verification of the URL scheme (for "http" or "https") of the server URL before invoking the plantuml_connection.

evandrocoan commented 5 years ago

Did you implemented it because it was slow before?

xenofanes9 commented 5 years ago

I believe I noticed a small speed-up, but didn't time it. Was also cluttering ST debug logs like crazy, as the whole zipped content URL was being dumped each time.

evandrocoan commented 5 years ago

I see. Thanks!