search

evangipson / midio

midio will work really hard to generate you endlessly interesting audio on the fly.
http://evangipson.com/midio
GNU Affero General Public License v3.0
21 stars 0 forks source link

Sometimes clicking doesn't generate a circle/note #17

Closed evangipson closed 6 years ago

evangipson commented 6 years ago

I have a hunch this is because the note is being created, but with such low volume that drawNoteWithVolumeOpacity or whatever isn't passing some threshold.

evangipson commented 6 years ago

Gonna do some more testing right now, but https://github.com/evangipson/midio/commit/aa9988c0f041eca1f4d88d4b367726c38fe1b3bd was an effort to fix this.

evangipson commented 6 years ago

Also got some more debug statements in to hopefully track this down as of https://github.com/evangipson/midio/commit/69429d8007ad9ce334cbab8f46c3f8737e9dc7ba

evangipson commented 6 years ago

This is due to user clicks being modified in getArpeggioFromNote(), getChordFromNote(), getMelodyFromNote().

evangipson commented 6 years ago

This is going to be handled in https://github.com/evangipson/midio/issues/23 now.