evanjflack / bacondecomp

Bacon-Goodman decomposition for differences-in-differences with variation in treatment timing.
Other
46 stars 16 forks source link

Testing #58

Closed joel-becker closed 4 years ago

joel-becker commented 4 years ago

Hi @evanjflack @EdJeeOnGitHub -- how does your testing workflow work?

My understanding was that .travis.yml would automatically run your testthat tests upon pushes to master.

But this understanding seems incomplete. The former file seems to quote this script, and other files seem to perform other checks. Could you help my understand what's going on here?

evanjflack commented 4 years ago

There are two different testing workflows. Travis executes everything in the testthat folder, the second file you reference is the R CMD check, which doesn’t run the testthat things, but rather looks to see if you have functions from other packages that aren’t imported, and other R package specific things.

evanjflack commented 4 years ago

@joel-becker check this out

http://r-pkgs.had.co.nz/check.html

Ed Edit: R CMD Check will also run all the tests in tests/ too.

EdJeeOnGitHub commented 4 years ago

Also we're using both github actions and travis to test stuff which is a little overkill which might add to the confusion.

joel-becker commented 4 years ago

Thank you for all the above, both!

To be sure I understand, does Ed's comment + edit mean that:

Also Evan, I'm not sure from your comment what codecov.yml is doing?

EdJeeOnGitHub commented 4 years ago

This might help break down GitHub Actions: image

We borrowed heavily from here: https://github.com/r-lib/actions/tree/master/examples.

Travis is running codecov.yml which assesses how much of the code is tested vs untested (and therefore incidentally runs the tests).

Also @evanjflack we need to update the badges to link to travis-ci.com since we've migrated - the badges will still work but clicking through the link leads to another redirect.

joel-becker commented 4 years ago

Thank you again! Time to experiment myself now.

Closing thread; assume it'd be better for @evanjflack to update badges through a quick commit or a new issue.