evanlabs / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

ninja windows generator does not honor resource_include_dirs setting #332

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a target with a long list of include directories (for example, a 
dependency on WebKit).
2. Add resource files (*.rc) to the target.
3. Build using ninja on Windows.

What is the expected output? What do you see instead?
Resource files should compile successfully. Instead, while attempting to 
compile resource files the RC tool fails with the following error:

The command line is too long.

What version of the product are you using? On what operating system?
Windows 7 64-bit. Gyp revision 1602.

Please provide any additional information below.
The MSVS generator works around this problem by providing a 
'resource_include_dirs' setting that overrides the 'include_dirs' setting when 
compiling resource files.

Original issue reported on code.google.com by marshall@chromium.org on 9 Apr 2013 at 7:11

GoogleCodeExporter commented 9 years ago
Seems to be fixed by as r1777.

Original comment by yukawa@chromium.org on 23 Nov 2013 at 5:54