search

evanlucas / fish-kubectl-completions

kubectl completions for fish shell
MIT License
576 stars 42 forks source link

Redirect stderr to null when getting with jsonpath #29

Closed femnad closed 3 years ago

femnad commented 3 years ago

Sorry for the PR spam today, I think this one manages to undo the sub-optimal changes I've introduced; if resource getting commands outputting to jsonpath redirect their stderr to /dev/null, then the completion output won't be mangled by templating errors from jsonpath if there are no resources of the completed type.

This patch in particular removes an avoidable CRD listing and prevents output mangling when completing kubectl rollout history if there are no deployments, daemonsets or statefulsets.

evanlucas commented 3 years ago

Thanks again! Just added you as a collaborator! Thanks for the help!