evanlucas / fish-kubectl-completions

kubectl completions for fish shell
MIT License
576 stars 42 forks source link

feat: add `--kubeconfig` flag support #38

Closed JonParton closed 3 years ago

JonParton commented 3 years ago

When using the --kubeconfig flag fish completions were ignoring this and utilising the default kubeconfig file or the one specified in the KUBECONFIG env variable.

This commit adds code that checks for the --kubeconfig PATH or --kubeconfig=PATH flags and passes them through when the completions use kubectl commands πŸ‘πŸΌπŸ‘πŸΌ.

closes #37

JonParton commented 3 years ago

Tested locally and seems to be working as expected and respecting the --kubeconfig flag when completing get pods, logs etc.

evanlucas commented 3 years ago

Thanks for contributing!