search

evanlucas / fish-kubectl-completions

kubectl completions for fish shell
MIT License
576 stars 42 forks source link

add support for config subcommand #5

Closed sidmutha closed 6 years ago

evanlucas commented 6 years ago

Thanks for the pull request. Is there any chance you could rebase this off of the master branch?

sidmutha commented 6 years ago

Sure.

sidmutha commented 6 years ago

I have rebased off master. One thing that I can't figure out is a clean way to add descriptions for the subcommands of config. Currently all of them say 'kube config subcommand'. Can you have a look?

evanlucas commented 6 years ago

I'm not sure if we will be able to add descriptions for the subcommands of config. I'd be fine with landing this without that though.

sidmutha commented 6 years ago

Done.

evanlucas commented 6 years ago

Thanks!