search

evanlucas / gcr

A node gitlab-ci-runner
MIT License
51 stars 12 forks source link

Problem with running a job #2

Closed ayufan closed 10 years ago

ayufan commented 10 years ago 
gcr http 404 https://gitlab-ci.ayufan.eu/api/v1/builds/register.json
gcr info [client] checking for builds...
gcr http 201 https://gitlab-ci.ayufan.eu/api/v1/builds/register.json
gcr info [client] submitting build 413 to coordinator...
gcr http PUT https://gitlab-ci.ayufan.eu/api/v1/builds/413.json
gcr http 200 https://gitlab-ci.ayufan.eu/api/v1/builds/413.json
gcr info [client] submitting build 413 to coordinator...
gcr http PUT https://gitlab-ci.ayufan.eu/api/v1/builds/413.json
gcr info [client] submitting build 413 to coordinator...
gcr http PUT https://gitlab-ci.ayufan.eu/api/v1/builds/413.json

/usr/local/lib/node_modules/gcr/lib/builder.js:238
    self.currentBuild.output += data
                     ^
TypeError: Cannot read property 'output' of null
    at Socket.<anonymous> (/usr/local/lib/node_modules/gcr/lib/builder.js:238:22)
    at Socket.EventEmitter.emit (events.js:95:17)
    at Socket.<anonymous> (_stream_readable.js:746:14)
    at Socket.EventEmitter.emit (events.js:92:17)
    at emitReadable_ (_stream_readable.js:408:10)
    at emitReadable (_stream_readable.js:404:5)
    at readableAddChunk (_stream_readable.js:165:9)
    at Socket.Readable.push (_stream_readable.js:127:10)
    at Pipe.onread (net.js:526:21)
evanlucas commented 10 years ago

hm, thats weird. It shouldn't be running a job if currentBuild is null. Ill have to look at that one.

ayufan commented 10 years ago

any update?

evanlucas commented 10 years ago

Probably will be tomorrow before I can get anything pushed. Sorry for the delay!

evanlucas commented 10 years ago

This should be fixed now. Had a chance to try the latest release?

evanlucas commented 10 years ago

The underlying issue was that there was a race condition that occurred in back to back builds. Fixed in 0.1.0.