search

evanlucas / gcr

A node gitlab-ci-runner
MIT License
51 stars 12 forks source link

The config for strictSSL is not handled correctly, it is always true #6

Closed Skywalker13 closed 9 years ago

Skywalker13 commented 10 years ago

You have:

strictSSL: gcr.config.get('strictSSL') || true

But it will be always true.. because false || true returns always true It seems that strictSSL is always stored in the config file, then it should be just

strictSSL: gcr.config.get('strictSSL')

Or if this config is optional (not available in the config file), then you should test if it's undefined..

Regards

evanlucas commented 9 years ago

ah good catch. PR welcome