search

evanlucas / gcr

A node gitlab-ci-runner
MIT License
51 stars 12 forks source link

add more info to readme #7

Closed flipflopsimsommer closed 9 years ago

flipflopsimsommer commented 9 years ago

i thought that might be usefull information

evanlucas commented 9 years ago

I like adding the comment about the config being saved. I do think the forever section should be more of a wiki page or something though. Possibly even adding additional options?

flipflopsimsommer commented 9 years ago

in the meantime i personally use pm2 instead of forever, it even starts after reboots and has better monitoring options. should i make a pull request containing only the configuration part? you should consider linking the wiki though.

evanlucas commented 9 years ago

Yea, that would be great. Feel free to add a wiki page with it if you want. :]

flipflopsimsommer commented 9 years ago

part one is done. i wrote a wiki about pm2 already i will adjust it for gcr next week

evanlucas commented 9 years ago

Thanks! Landed in 53ef873c6bd18ef0b6c195d0ed200702fd8ebc49 with a slightly modified commit message

flipflopsimsommer commented 9 years ago

just added the wiki, hope you like it - if so you might consider link it from the readme.md

btw you might update your npm modules, i tested it (in my envirument) with the latest versions, it works fine. but mybe there are cases where they woudn't work?

evanlucas commented 9 years ago

Awesome. That sounds great. Would definitely be open to a PR for adding it to the readme if you're interested. I also have plans to add a test suite as it is desperately needed. Just haven't had the time yet. :]

flipflopsimsommer commented 9 years ago

you already saved my time by writing the core, tell me where i can help, i can at least try... ;)