search

evanlucas / gcr

A node gitlab-ci-runner
MIT License
51 stars 12 forks source link

Execute commands with Bash #8

Closed lorenz closed 9 years ago

lorenz commented 9 years ago

This allows variable expansion, such as $CI_BUILD_ID

fzwoch commented 9 years ago

I think this would also allow the use of '#' to add comments to the scripts? Currently the execution will fail when trying to be descriptive.

Also using empty lines currently results in the whole ENV variable to be printed into the log as 'env' is called without any parameters. I often like to separate things by newlines to group things if the test process involves different steps.

evanlucas commented 9 years ago

Landed in ef3f7763b3ed0d128f782de062d7145e8fe9c6f2.

Thanks. @fzwoch I have been thinking of a way to do that better. I know the official CI Runner runs all of the commands as a single script. That may be the way to go...