tests do not succeed - Githubissues

it seems like tests depend on some external resource which is not available?

Version:

commit 1028b533bb1730311ef4ec1257f6f8f25725a998 (HEAD -> master, origin/master, origin/HEAD)
Author: ca333 <ca333@users.noreply.github.com>
Date:   Tue Aug 28 16:59:41 2018 +0200

    update travis

    removed old node versions that lead to failed build

    todo: add/test new/LTS node versons to CI scope

$ node --version
v12.9.1

$ uname -a
Darwin C02T81ZHH03Q 19.6.0 Darwin Kernel Version 19.6.0: Mon Aug 31 22:12:52 PDT 2020; root:xnu-6153.141.2~1/RELEASE_X86_64 x86_64

Reproduce:

$ npm install
npm WARN deprecated request@2.87.0: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.0.3: this library is no longer supported
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm notice created a lockfile as package-lock.json. You should commit this file.
added 300 packages from 179 contributors and audited 300 packages in 8.791s
found 12 vulnerabilities (5 low, 1 moderate, 5 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

$ npm test

> remote-file-size@3.0.5 test /Users/harrinm/work/remote-file-size
> tap test.js --cov

test.js .............................................. 6/12 3m
  should return null, size on success
  not ok err should not exist
    found:
      name: Error
      stack: |-
        Error: connect ETIMEDOUT 104.16.20.35:80
            at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1056:14)
      message: 'connect ETIMEDOUT 104.16.20.35:80'
      errno: ETIMEDOUT
      code: ETIMEDOUT
      syscall: connect
      address: 104.16.20.35
      port: 80
    at:
      line: 26
      column: 7
      file: test.js
    stack: |
      test.js:26:7
      Request._callback (index.js:1:4096)
      self.callback (node_modules/request/request.js:185:22)
      Request.onRequestError (node_modules/request/request.js:877:8)
    source: |
      t.ifError(err, 'err should not exist')

  should return null, size on success
  not ok out should exist
    at:
      line: 27
      column: 7
      file: test.js
    stack: |
      test.js:27:7
      Request._callback (index.js:1:4096)
      self.callback (node_modules/request/request.js:185:22)
      Request.onRequestError (node_modules/request/request.js:877:8)
    source: |
      t.ok(out, 'out should exist')

  should return null, size on success
  not ok should be equal
    --- wanted
    +++ found
    -1548
    +[null]
    compare: '==='
    at:
      line: 28
      column: 7
      file: test.js
    stack: |
      test.js:28:7
      Request._callback (index.js:1:4096)
      self.callback (node_modules/request/request.js:185:22)
      Request.onRequestError (node_modules/request/request.js:877:8)
    source: |
      t.equal(out, 1548)

  should work passing an object
  not ok err should not exist
    found:
      name: Error
      stack: |-
        Error: connect ETIMEDOUT 104.16.20.35:80
            at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1056:14)
      message: 'connect ETIMEDOUT 104.16.20.35:80'
      errno: ETIMEDOUT
      code: ETIMEDOUT
      syscall: connect
      address: 104.16.20.35
      port: 80
    at:
      line: 39
      column: 7
      file: test.js
    stack: |
      test.js:39:7
      Request._callback (index.js:1:4096)
      self.callback (node_modules/request/request.js:185:22)
      Request.onRequestError (node_modules/request/request.js:877:8)
    source: |
      t.ifError(err, 'err should not exist')

  should work passing an object
  not ok out should exist
    at:
      line: 40
      column: 7
      file: test.js
    stack: |
      test.js:40:7
      Request._callback (index.js:1:4096)
      self.callback (node_modules/request/request.js:185:22)
      Request.onRequestError (node_modules/request/request.js:877:8)
    source: |
      t.ok(out, 'out should exist')

  should work passing an object
  not ok should be equal
    --- wanted
    +++ found
    -1548
    +[null]
    compare: '==='
    at:
      line: 41
      column: 7
      file: test.js
    stack: |
      test.js:41:7
      Request._callback (index.js:1:4096)
      self.callback (node_modules/request/request.js:185:22)
      Request.onRequestError (node_modules/request/request.js:877:8)
    source: |
      t.equal(out, 1548)

total ................................................ 6/12

  6 passing (3m)
  6 failing

----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |    80.95 |    66.67 |      100 |       80 |                   |
 index.js |    80.95 |    66.67 |      100 |       80 |       28,29,30,33 |
----------|----------|----------|----------|----------|-------------------|
npm ERR! Test failed.  See above for more details.

evanlucas / remote-file-size

tests do not succeed #11