evannetwork / api-blockchain-core

blockchain programming framework for evan.network
GNU Affero General Public License v3.0
5 stars 1 forks source link

fix profile creation #114

Closed S3bb1 closed 4 years ago

S3bb1 commented 4 years ago
codecov-io commented 4 years ago

Codecov Report

Merging #114 into develop will decrease coverage by 20.26%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #114       +/-   ##
============================================
- Coverage    86.52%   66.26%   -20.27%     
============================================
  Files           49       49               
  Lines         6317     6323        +6     
  Branches      1459     1459               
============================================
- Hits          5466     4190     -1276     
- Misses         848     2130     +1282     
  Partials         3        3               
Flag Coverage Δ
#javascript 66.26% <0.00%> (-20.27%) :arrow_down:
Impacted Files Coverage Δ
src/onboarding.ts 5.92% <0.00%> (-88.52%) :arrow_down:
libs/bitcore-mnemonic/pbkdf2.js 5.55% <0.00%> (-86.12%) :arrow_down:
src/profile/business-center-profile.ts 4.44% <0.00%> (-71.12%) :arrow_down:
libs/bitcore-mnemonic/mnemonic.js 16.50% <0.00%> (-70.88%) :arrow_down:
src/payments.ts 3.58% <0.00%> (-65.48%) :arrow_down:
src/name-resolver.ts 4.81% <0.00%> (-62.66%) :arrow_down:
src/verifications/verifications.ts 40.05% <0.00%> (-51.87%) :arrow_down:
src/keyExchange.ts 45.45% <0.00%> (-50.00%) :arrow_down:
libs/eth-lightwallet/keystore.js 14.55% <0.00%> (-47.77%) :arrow_down:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update beb8581...89a7222. Read the comment docs.

wulfraem commented 4 years ago

@karladler

coverage decreases drastically just by those two lines :/

Unfortunately there seems to be an issue with updating Codecov's post. When you click on the "#114" in its post, the difference doesn't look that bad. ^^