search

evanphx / benchmark-ips

Provides iteration per second benchmarking for Ruby
MIT License
1.72k stars 97 forks source link

Include all *.rb files in lib/ into the gem #117

Closed janko closed 3 years ago

janko commented 3 years ago

Alternative fix for https://github.com/evanphx/benchmark-ips/issues/116. This is the strategy I use in all of my gems, to include all ruby files in the lib/ directory. I also removed Manifest.txt, so that it doesn't need to be updated anymore.

evanphx commented 3 years ago

I'd rather manually maintain the list.

eregon commented 3 years ago

Unfortunate, since maintaining that list manually has proven to be error-prone and caused already 4 broken releases: https://github.com/evanphx/benchmark-ips/pull/115#issue-650569811

But here is another way to ensure this issue does not happen again: https://github.com/evanphx/benchmark-ips/pull/118