evanphx / benchmark-ips

Provides iteration per second benchmarking for Ruby
MIT License
1.72k stars 97 forks source link

reduces calc overhead of suffix helper method #128

Closed jtbg closed 1 year ago

jtbg commented 1 year ago

if only there were some sort of tool we could use to measure the performance gains

jtbg commented 1 year ago

thanks for reminding me @kbrock

kbrock commented 1 year ago

Aah, I was confused because you commented on a commit that had changes not here. This PR is just picking off the obvious win. 👍

kbrock commented 1 year ago

hmm... could you remove the merge commit, and rebase this onto master?

(sorry if you already know this stuff)

git fetch upstream
git checkout scale_helper_optimization
git branch scale_helper_optimization_bak # just in case
git reset --hard HEAD~1 # drop the merge commit
git rebase upstream/master

git diff scale_helper_optimization_bak # should be the same
git log -3 # this branch should just have a single commit
jtbg commented 1 year ago

WHat does git branch scale_helper_optimization_bak do here? I've never seen that before

edit: oh I get it, that is just creating a new, identical branch

jtbg commented 1 year ago

This is why I always get @emgreen33 to untangle my git spaghetti for me :rofl: Thanks for the help!