Closed jtbg closed 1 year ago
thanks for reminding me @kbrock
Aah, I was confused because you commented on a commit that had changes not here. This PR is just picking off the obvious win. 👍
hmm... could you remove the merge commit, and rebase this onto master?
(sorry if you already know this stuff)
git fetch upstream
git checkout scale_helper_optimization
git branch scale_helper_optimization_bak # just in case
git reset --hard HEAD~1 # drop the merge commit
git rebase upstream/master
git diff scale_helper_optimization_bak # should be the same
git log -3 # this branch should just have a single commit
WHat does git branch scale_helper_optimization_bak
do here? I've never seen that before
edit: oh I get it, that is just creating a new, identical branch
This is why I always get @emgreen33 to untangle my git spaghetti for me :rofl: Thanks for the help!
if only there were some sort of tool we could use to measure the performance gains